Review

Workflow: Review

Review a PR for architectural fit, security, and quality.

When to Use

• Ticket is in review with an open PR
• CTO or designated reviewer needs to assess the changes

Inputs

• Issue identifier, title, and description
• The PR diff and associated branch
• The target repo’s codebase for context

Steps

1. Find the PR — locate the PR associated with this issue (check issue comments for links, or search open PRs on the repo)
2. Review the diff for:
   • Architecture: Does the approach fit existing patterns?
   • Security: Any injection vectors, secrets, or privilege issues?
   • Tests: Are new/changed behaviours tested?
   • Quality: Lint clean, type safe, no regressions?
   • Scope: Changes relate only to this ticket? No unrelated changes bundled in?
   • Layers: All delivery layers identified in the ticket are addressed?
3. Approve or request changes:
   • If the PR passes review, approve it with a summary comment
   • If changes are needed, request changes with specific, actionable feedback

Quality Checks

• PR corresponds to exactly one ticket
• All CI checks are passing
• No secrets or sensitive data in the diff
• Tests cover the new/changed behaviour

References

• See “Pull Request Process” and “Definition of Done” in .ai/projects/cascadeguard/sdlc.md